Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 通用组件的渲染统一 #168

Closed
wants to merge 8 commits into from

Conversation

chaorenluo
Copy link
Contributor

目前开源的组件方案只维护了题型组件的渲染统一,其余组件如头图,欢迎语,提交按钮和logo分别在b端和c端分别实现一套,将其余组件也维护在物料层
image
1,新增HeaderContent(头图),MainTitle(欢迎语),SubmitButton(提交按钮),LogoIcon(logo)适配B,C端差异
2.新增communalLoader.js 文字用来动态加载组件
image
3.xiaoju-survey/web/src/management/pages/edit/modules/questionModule/PreviewPanel.vue 重构为vue3 。
4.xiaoju-survey/web/src/management/pages/edit/modules/settingModule/skin/PreviewPanel.vue 重构为vue3 。
5.将之前B,C端个自实现的组件统一替换成新的适配组件方便维护

@@ -0,0 +1,93 @@
import { defineComponent, computed } from 'vue'
import RichEditor from '@/common/Editor/RichEditor.vue'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C端也间接引用了RichEditor,是否改成defineAsyncComponent方式引入,类似CheckboxModule里selectMoreView的容器引入方式

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 已修改

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
渲染效果并不一致

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改保持一致

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在宽度一致的前提下,B端和C端渲染效果不一致
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改保持一致

web/src/materials/communals/communalLoader.js Outdated Show resolved Hide resolved
@@ -1,29 +1,32 @@
<template>
<div class="index">
<ProgressBar />
<progressBar />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

统一用大驼峰写法,保留ProgressBar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已处理

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先反向同步一下develop,部分代码已修改,目前又覆盖回去了

@chaorenluo chaorenluo closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants